[KP] Expose new es client #73651
Merged
[KP] Expose new es client #73651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
Team:Core
mshustov
force-pushed
the
expose-new-es-client
branch
from
338954a to
e4bbdf5
Compare
14 tasks
|
Pinging @elastic/kibana-platform (Team:Platform) |
joshdover
approved these changes
Jul 29, 2020
test/plugin_functional/plugins/elasticsearch_client_plugin/server/plugin.ts
Show resolved
Hide resolved
mshustov
commented
Jul 30, 2020
| @@ -22,6 +22,7 @@ import { CatTasksParams } from 'elasticsearch'; | |||
| import { CatThreadPoolParams } from 'elasticsearch'; | |||
| import { ClearScrollParams } from 'elasticsearch'; | |||
| import { Client } from 'elasticsearch'; | |||
| import { ClientOptions } from '@elastic/elasticsearch'; | |||
There was a problem hiding this comment.
no idea why it's here. it's not used in the file
lukeelmers
approved these changes
Jul 30, 2020
| @@ -22,6 +22,7 @@ import { CatTasksParams } from 'elasticsearch'; | |||
| import { CatThreadPoolParams } from 'elasticsearch'; | |||
| import { ClearScrollParams } from 'elasticsearch'; | |||
| import { Client } from 'elasticsearch'; | |||
| import { ClientOptions } from '@elastic/elasticsearch'; | |||
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
Jul 30, 2020
* mark legacy ES client types as deprecated * expose es client to plugins and update mocks * ElasticSearchClientMock --> ElasticsearchClientMock * expose es client mocks * expose es client via RequestHandlerContext * convert test/plugin_functional/config into ts * convert top_nav test into ts * add an integration test for the es client * update comments to refer to the new es client * fix import paths. do not use extensions temp * update docs * fix other refs * add test for a custom client * fix context * add test for scoped client * update docs # Conflicts: # scripts/functional_tests.js
mshustov
added a commit
that referenced
this pull request
Jul 30, 2020
* mark legacy ES client types as deprecated * expose es client to plugins and update mocks * ElasticSearchClientMock --> ElasticsearchClientMock * expose es client mocks * expose es client via RequestHandlerContext * convert test/plugin_functional/config into ts * convert top_nav test into ts * add an integration test for the es client * update comments to refer to the new es client * fix import paths. do not use extensions temp * update docs * fix other refs * add test for a custom client * fix context * add test for scoped client * update docs # Conflicts: # scripts/functional_tests.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR exposes new elasticsearch client to the plugins on the server-side. The new client is available via:
requestHandlerContextcoreStartcontract of the elasticsearch service:Migration guide for the new elasticsearch client available in https://github.com/elastic/kibana/blob/master/src/core/MIGRATION_EXAMPLES.md#elasticsearch-client
The legacy client is going to be deprecated and removed in
7.x.Checklist
Delete any items that are not applicable to this PR.
For maintainers
Dev Docs
Kibana provides the new elasticsearch client as a part of the elasticsearch service on the server-side. The legacy client is deprecated on and subject for removal in
7.x. Reference the provided migration guide to refactor your code https://github.com/elastic/kibana/blob/master/src/core/MIGRATION_EXAMPLES.md#elasticsearch-client